Skip to content

modify save model in lite module#4624

Open
43758726 wants to merge 1 commit into
InternLM:mainfrom
43758726:lite_awq_modify_model_save
Open

modify save model in lite module#4624
43758726 wants to merge 1 commit into
InternLM:mainfrom
43758726:lite_awq_modify_model_save

Conversation

@43758726
Copy link
Copy Markdown
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copilot AI review requested due to automatic review settings May 26, 2026 12:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

allfiles = os.listdir(model_path)
for file in allfiles:
if not file.endswith('.py'):
def copy_others(model: Path, work_dir: Path):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy_others is unclear. It copies everything except weight files. Prefer copy_non_weight_files with src_dir / dst_dir.
It is shared by multiple APIs, so don’t keep it in auto_awq.py. Rename load.py → io.py and put this helper there, then import from lmdeploy.lite.utils.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants