Repository navigation
Fix Appendix A Google Metro Codes link to point at the actual metro/DMA data - #185
Open
sujanchalla0510 wants to merge 1 commit into
Conversation
…MA data The `Geo.metro` field (section 3.2.19) is documented as a "Google metro code; similar to but not exactly Nielsen DMAs," directing readers to Appendix A for the codes. Appendix A's "Google Metro Codes" entry links to the Google Ads geotargets reference (developers.google.com/google-ads/api/reference/data/geotargets), whose CSV has no metro or DMA concept at all - its Target Types are Country, State, City, Postal Code, etc. Google's own Authorized Buyers RTB guide (developers.google.com/authorized-buyers/rtb/openrtb-guide) instead references a different file, geo-table.csv, for RTB geo targeting. Downloaded and inspected that file directly: it contains 210 rows with Target_Type "DMA Region", Criteria_IDs in the 200500-200881 range, and names that are exactly Nielsen DMA codes offset by 200000 (e.g. 200501 = "New York, NY" = Nielsen DMA 501; 200803 = "Los Angeles, CA" = DMA 803; 200602 = "Chicago, IL" = DMA 602; 200807 = "San Francisco-Oakland-San Jose, CA" = DMA 807) - matching the spec's own "similar to but not exactly Nielsen DMAs" description precisely. Updates the Appendix A link to the correct file, noting which rows to use and citing the Google guide that references it. Related to InteractiveAdvertisingBureau#180, InteractiveAdvertisingBureau#153 (the original dead link fix that swapped in this still-incorrect replacement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180.
Summary
Geo.metro(§3.2.19) is documented as a "Google metro code; similar tobut not exactly Nielsen DMAs," directing readers to Appendix A for the
codes. Appendix A's "Google Metro Codes" entry links to the Google Ads
geotargets reference,
whose CSV has no metro or DMA concept at all — its Target Types are
Country, State, City, Postal Code, etc. (confirmed by the issue reporter
by downloading and inspecting the CSV directly).
Investigation
Google's own Authorized Buyers RTB guide
instead references a different file,
geo-table.csv, for RTB geotargeting. I downloaded and inspected that file directly (not just the
issue's excerpt) to verify before proposing a fix:
Target_Type="DMA Region", withCriteria_IDs inthe 200500–200881 range.
200501→"New York, NY"(Nielsen DMA 501)200803→"Los Angeles, CA"(Nielsen DMA 803)200602→"Chicago, IL"(Nielsen DMA 602)200807→"San Francisco-Oakland-San Jose, CA"(Nielsen DMA 807)This matches the spec's own description — "similar to but not exactly
Nielsen DMAs" — exactly.
Fix
Updates the Appendix A link to
geo-table.csv, notes which rows to use(
Target_Type="DMA Region"), and cites the Google guide thatreferences it, so the link and the field description are finally
consistent.
Related to #153, the original dead-link fix that (unknowingly) swapped
in this still-incorrect replacement link.