Repository navigation
Conversation
Collaborator
|
Please make the equivalent edits to |
Author
|
Done — mirrored the change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hp description states that when hp=1, the seller in sid is "responsible for paying the previous node in the chain." With SupplyChain 1.1, an hp=0 node can precede the first payment node — the Supply Chain Validation Implementation Guidance notes implementers should expect one or more hp=0 nodes in front of the first payment handling node — and in that arrangement the previous node is not paid by the seller, so the description is incorrect as written.
The Implementation Guidance validation methods (section 4.6) already use the correct formulation: the payment linkage runs between hp=1 nodes ("should match the advertising system in the preceding hp=1 node"). This change aligns the field description to it and adds that hp=0 nodes are not part of the payment linkage. For version 1.0 chains, where all nodes are payment handling, the preceding hp=1 node is the previous node, so nothing changes.
Part of the public comment feedback for InteractiveAdvertisingBureau/Supply-Chain-Validation#1.