Skip to content

fix(ui): edge-to-edge bottom-tab overlap + back button closing the app (targetSdk 37)#52

Merged
InfinityLoop1308 merged 3 commits into
InfinityLoop1308:devfrom
Priveetee:fix/2486-bottom-inset-and-back
Jun 15, 2026
Merged

fix(ui): edge-to-edge bottom-tab overlap + back button closing the app (targetSdk 37)#52
InfinityLoop1308 merged 3 commits into
InfinityLoop1308:devfrom
Priveetee:fix/2486-bottom-inset-and-back

Conversation

@Priveetee

Copy link
Copy Markdown
Contributor

hey! this fixes both bugs from the 5.2.0-beta report in
#2486 — Layout overlap issue, bottom UI
(the bottom UI overlapping the nav bar, and the back button closing the app). both turned
out to be fallout from the targetSdk 37 bump, and your hunches in the thread were spot on :)

what was happening

  • the bottom tab strips (video detail comments/related/description/sponsorblock, and the
    main tabs when they're at the bottom) were drawing under the 3-button nav bar. targetSdk

    =35 forces edge-to-edge, so anything anchored to the bottom that doesn't consume the
    nav-bar inset ends up behind it.

  • the back button just closed the app: on android 16 back goes through OnBackInvokedCallback,
    and since we're on old androidx with nothing registered, the activity finished outright and
    our whole onBackPressed/BackPressable chain got skipped.

what i changed

  • VideoDetailFragment / MainFragment: pad the tab strips by the nav-bar inset (and bump the
    pager's bottom padding to match). adapts on its own to gesture nav.
  • AndroidManifest: enableOnBackInvokedCallback="false" so back keeps going to the legacy
    onBackPressed like before.

just +32 lines across 3 files, nothing touched outside these paths.

how i tested it

emulator, Pixel 8 AVD, android 16 (API 36), edge-to-edge on:

  • tabs: before they sat under the nav bar, after they're above it (3-button); gesture nav
    unaffected; checked main-tabs-bottom and landscape too
  • back: confirmed via logcat that onBackPressed fires again; tested home, search->home,
    detail collapse, fullscreen exit, and double-back still exits the app

heads up: only on the emulator for now, i'll try it on my actual phone once i'm back home,
but i'd bet it's the same result :)

Fixes InfinityLoop1308/PipePipe#2486

@Priveetee

Copy link
Copy Markdown
Contributor Author

Testing on my phone rn

@Priveetee Priveetee marked this pull request as draft June 15, 2026 15:07
@Priveetee

Copy link
Copy Markdown
Contributor Author

I didn't catch a detail on the emulator pushing the commit now

@Priveetee Priveetee marked this pull request as ready for review June 15, 2026 15:18
@InfinityLoop1308

Copy link
Copy Markdown
Owner

🚀

@InfinityLoop1308 InfinityLoop1308 merged commit 32ff0f0 into InfinityLoop1308:dev Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][5.2.0-beta] Layout overlap issue - bottom UI

2 participants