fix(ui): edge-to-edge bottom-tab overlap + back button closing the app (targetSdk 37)#52
Merged
InfinityLoop1308 merged 3 commits intoJun 15, 2026
Conversation
Contributor
Author
|
Testing on my phone rn |
Contributor
Author
|
I didn't catch a detail on the emulator pushing the commit now |
…oesn't show through the nav inset
Owner
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey! this fixes both bugs from the 5.2.0-beta report in
#2486 — Layout overlap issue, bottom UI
(the bottom UI overlapping the nav bar, and the back button closing the app). both turned
out to be fallout from the targetSdk 37 bump, and your hunches in the thread were spot on :)
what was happening
main tabs when they're at the bottom) were drawing under the 3-button nav bar. targetSdk
and since we're on old androidx with nothing registered, the activity finished outright and
our whole onBackPressed/BackPressable chain got skipped.
what i changed
pager's bottom padding to match). adapts on its own to gesture nav.
onBackPressed like before.
just +32 lines across 3 files, nothing touched outside these paths.
how i tested it
emulator, Pixel 8 AVD, android 16 (API 36), edge-to-edge on:
unaffected; checked main-tabs-bottom and landscape too
detail collapse, fullscreen exit, and double-back still exits the app
heads up: only on the emulator for now, i'll try it on my actual phone once i'm back home,
but i'd bet it's the same result :)
Fixes InfinityLoop1308/PipePipe#2486