feat: support hygon flash attn 2#1348
Merged
Merged
Conversation
| #if defined(ENABLE_HYGON_API) | ||
| #include <c10/hip/HIPFunctions.h> | ||
| #include <c10/hip/HIPGuard.h> | ||
| #elif defined(ENABLE_NVIDIA_API) || defined(ENABLE_METAX_API) || defined(ENABLE_QY_API) |
Collaborator
There was a problem hiding this comment.
在专门的海光命令的mha_varlen_flashattn_hygon.cc文件中，还需要考虑其他平台的宏么？defined(ENABLE_NVIDIA_API) || defined(ENABLE_METAX_API) || defined(ENABLE_QY_API)
Collaborator
Author
There was a problem hiding this comment.
不用，默认是把海光这个文件夹移除了的，别的平台不会编。
另外我觉得别的平台以后也得拆开，不然那几个文件越写越恶心了
wooway777
force-pushed
the
feat/support-hygon-fa2
branch
from
cc30e67 to
b967a54
Compare
wooway777
force-pushed
the
feat/support-hygon-fa2
branch
from
b967a54 to
7d634d2
Compare
wooway777
force-pushed
the
feat/support-hygon-fa2
branch
from
7d634d2 to
ef7b5ac
Compare
pengcheng888
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.