fix(dialog): render asynchronous open state in zoneless apps#17447
Open
viktorkombov wants to merge 2 commits into
Open
fix(dialog): render asynchronous open state in zoneless apps#17447viktorkombov wants to merge 2 commits into
viktorkombov wants to merge 2 commits into
Conversation
viktorkombov
added
dialog
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a zoneless change-detection edge case where IgxDialogComponent stays visually hidden when isOpen is flipped asynchronously (e.g. via setTimeout + signal-bound input), by explicitly scheduling a check after the deferred open() call.
Changes:
- Injects
ChangeDetectorRefinIgxDialogComponentand callsmarkForCheck()after therequestAnimationFrame-deferredopen()triggered by theisOpeninput setter. - Adds a zoneless regression test using
provideZonelessChangeDetection()and asignalbound to[isOpen]to validate DOM visibility and host hidden class synchronization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/dialog/src/dialog/dialog.component.ts | Ensures the dialog host binding/class state is re-rendered after the async open() path in zoneless apps. |
| projects/igniteui-angular/dialog/src/dialog/dialog.component.spec.ts | Adds regression coverage for async signal-driven isOpen updates under zoneless change detection. |
Comment on lines
+739
to
+744
| const dialogWindow = document.querySelector<HTMLElement>(DIALOG_WINDOW); | ||
| expect(dialog.isOpen).toBeTrue(); | ||
| expect(dialog.isCollapsed).toBeFalse(); | ||
| expect(dialogWindow).withContext('dialog window is in the DOM').not.toBeNull(); | ||
| expect(dialogWindow.getClientRects().length) | ||
| .withContext('dialog window is actually rendered').toBeGreaterThan(0); |
mddragnev
added
✅ status: verified
rkaraivanov
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17443
Description
Fixes the Dialog remaining hidden when its
isOpeninput is updatedasynchronously in a zoneless application.
Adds regression coverage using a signal-bound
isOpeninput.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)