fix(month-picker): update keyboard navigation in zoneless apps#17445
Open
viktorkombov wants to merge 2 commits into
Open
fix(month-picker): update keyboard navigation in zoneless apps#17445viktorkombov wants to merge 2 commits into
viktorkombov wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a zoneless-change-detection rendering gap in the Calendar Month Picker where keyboard navigation updates internal state but doesn’t reliably trigger a view refresh, leaving the highlighted month stale in zoneless apps.
Changes:
- Update
KeyboardNavigationServicekeydown handling to trigger change detection after executing a key handler. - Add a zoneless regression spec to verify highlighted-month updates after keyboard navigation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
projects/igniteui-angular/calendar/src/calendar/calendar.services.ts |
Adds change-detection signaling after keyboard handler execution to support zoneless rendering updates. |
projects/igniteui-angular/calendar/src/calendar/month-picker/month-picker.component.spec.ts |
Introduces a zoneless regression test covering keyboard navigation highlight updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17438
Description
Fixes the Month Picker highlight not updating after keyboard navigation in
zoneless applications.
Adds zoneless regression coverage for the keyboard navigation behavior.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)