Fix #873: ThresholdInterval throws StackOverflowException.#876
Conversation
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @bewshy Details
|
|
cla has been signed |
Fixes code styling
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @bewshy Details
|
|
Thank you very much for the PR! I just fixed the code styling by using the correct indents. But I can confirm the issue and the fix. I will check with Blerim regarding the cla-bot and once it is completed and the changelog is updated, I will merge the PR. It will be included with the v1.15.0 release von June 30th. Thank you again for the contribution!! |
When -ThresholdInterval is used but no metrics data has been collected, Compare-IcingaPluginThresholds returns HasError = $true' but the problem is how that error is handled which causes a loop. This proposed fix now returns a graceful [UNKNOWN]with[Failed to parse metrics over time with -ThresholdInterval "": No data found...]`