Skip to content

Fix #873: ThresholdInterval throws StackOverflowException.#876

Open
bewshy wants to merge 2 commits into
Icinga:masterfrom
bewshy:fix/ThresholdInterval_throws_StackOverflowException
Open

Fix #873: ThresholdInterval throws StackOverflowException.#876
bewshy wants to merge 2 commits into
Icinga:masterfrom
bewshy:fix/ThresholdInterval_throws_StackOverflowException

Conversation

@bewshy

@bewshy bewshy commented Jun 11, 2026

Copy link
Copy Markdown

When -ThresholdInterval is used but no metrics data has been collected, Compare-IcingaPluginThresholds returns HasError = $true' but the problem is how that error is handled which causes a loop. This proposed fix now returns a graceful [UNKNOWN]with[Failed to parse metrics over time with -ThresholdInterval "": No data found...]`

@cla-bot

cla-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @bewshy

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bewshy

bewshy commented Jun 11, 2026

Copy link
Copy Markdown
Author

cla has been signed

@bewshy bewshy changed the title fix for ThresholdInterval_throws_StackOverflowException Fix #873: ThresholdInterval throws StackOverflowException. Jun 11, 2026
@LordHepipud LordHepipud added the Bug There is an issue present label Jun 19, 2026
@LordHepipud LordHepipud added this to the v1.15.0 milestone Jun 19, 2026
Fixes code styling
@cla-bot

cla-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @bewshy

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@LordHepipud

Copy link
Copy Markdown
Collaborator

Thank you very much for the PR! I just fixed the code styling by using the correct indents. But I can confirm the issue and the fix.
Could you please update the PR by updating the changelog:

## 1.15.0 (2026-06-30)

[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/44)

### Bugfixes

* [#873](https://github.com/Icinga/icinga-powershell-framework/issues/873) Fixes `StackOverflowException` while using `-ThresholdInterval` if no Metrics over Time are present [@bewshy]

I will check with Blerim regarding the cla-bot and once it is completed and the changelog is updated, I will merge the PR. It will be included with the v1.15.0 release von June 30th.

Thank you again for the contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug There is an issue present

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants