Conversation
- Makefile: export compose-matching JWT_SECRET_KEY and PLATFORM_ADMIN_PASSWORD in run_playwright_test — test-minted JWTs were signed with the config-default 'changeme' secret while the gateway validates with the compose secret, so ~150 tests failed with 401 'Invalid authentication credentials' - conftest: admin_api fixture's JWT fallback called unimported _create_jwt_token (NameError swallowed by 'except Exception: pass'), producing an empty token; use make_test_jwt with the same claims as the working api_request_context fixture - test_edit_modal_auth_type_oauth_fields: no longer assumes table row 0 is non-OAuth (leftover OAuth test gateways from other suites legitimately render OAuth fields on open); picks a non-OAuth gateway from the API and opens it by name via new GatewaysPage.open_edit_modal_by_name (client-side search filters leave hidden rows in the DOM that index-based selection trips on) - test_select_all_prompts_survives_search: create and clean up a prompt so the modal's prompt list is never empty (a DB holding only team-scoped prompts from other suites timed out the wait) - test_developer_rpc_tools_call_not_denied: replace external httpbin.org tool URL with a local fast-404 endpoint — degraded httpbin returned retryable 503s, and the gateway's exponential backoff pushed the call past the client timeout Signed-off-by: Jonathan Springer <jps@s390x.com>
jonpspri
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
September 22, 2026 10:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the Playwright UI suite so it runs green against the standard compose testing stack.
What was broken
changemesecret while the compose gateway validates with the compose secret.admin_apifixture fell back silently: its JWT path called an unimported helper; the swallowedNameErrorproduced an empty token.test_edit_modal_auth_type_oauth_fieldsflaked: it assumed table row 0 is non-OAuth; leftover OAuth gateways from sibling suites broke that.test_select_all_prompts_survives_searchtimed out: a DB holding only team-scoped prompts left the modal list empty.test_developer_rpc_tools_call_not_deniedhit httpbin.org: degraded externals returned retryable 503s, and the gateway backoff pushed past the client timeout.Fixes
run_playwright_testexports the compose-matchingJWT_SECRET_KEYandPLATFORM_ADMIN_PASSWORD.admin_apifallback usesmake_test_jwtwith the same claims as the workingapi_request_contextfixture.GatewaysPage.open_edit_modal_by_name), avoiding hidden DOM rows left by client-side search.Signed-off-by: Jonathan Springer jps@s390x.com