(fix) dictionary too big -> out of memory - #286
Open
sarahmccuan wants to merge 3 commits into
Open
Conversation
change volume to named volume rather than host bind mount
Author
|
It looks like your develop branch has updates that weren't in main already (which is what I was working off of). I can fix these but not sure if you want to go ahead and merge to main first? lmk what you prefer. |
sarahmccuan
changed the title
Author
|
Oh lol I see it looks like you already addressed the bug in another pr that's in develop - I missed the comment on the original issue. Lemme pull develop & test that the fix works. if so I'll just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed my issues with the German dictionaries overloading memory. Basically we just scan through entries individually and discard anything slow.
I was worried about how long it would take for super large dictionaries vs. just pulling everything into memory but there's no real noticeable impact (and it works now vs failing completely so I'll take that as a win).