Skip to content

update GUI et Icon#7

Open
SINF-KEN wants to merge 3 commits into
Hokkaydo:masterfrom
SINF-KEN:master
Open

update GUI et Icon#7
SINF-KEN wants to merge 3 commits into
Hokkaydo:masterfrom
SINF-KEN:master

Conversation

@SINF-KEN

Copy link
Copy Markdown

No description provided.

@tdaron

tdaron commented Dec 9, 2023

Copy link
Copy Markdown
Contributor

There isn't any change for Chrome ? is it intentional ?

@SINF-KEN

SINF-KEN commented Dec 9, 2023

Copy link
Copy Markdown
Author

yes. Chrome's changes don't concern me - my focus is on maintaining Firefox's superior features and customization options. use firefox.

also didn't test it on chrome, so i won't PR something i don't test.

@Hokkaydo

Hokkaydo commented Dec 9, 2023

Copy link
Copy Markdown
Owner

yes. Chrome's changes don't concern me - my focus is on maintaining Firefox's superior features and customization options. use firefox.

also didn't test it on chrome, so i won't PR something i don't test.

It would be nice to keep Firefox and Chrome versions aligned.
I'd like you to at least push code that could work. I'll review, test and, if needed, fix it

- removed "webRequestBlocking"
- updated the icon to use the 48px icon 👍
fixed typo in file ( manifest )
updated the popup GUI
@SINF-KEN

SINF-KEN commented Dec 9, 2023

Copy link
Copy Markdown
Author

Versions should be aligned 🚀

@Hokkaydo

Copy link
Copy Markdown
Owner

Perfect, thank you very much
I will try both extensions as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants