Skip to content

[core] much better referer handling - #135

Open
velzie wants to merge 7 commits into
developfrom
feat/referer-fix-2
Open

velzie wants to merge 7 commits into
developfrom
feat/referer-fix-2

Conversation

@velzie

@velzie velzie commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

must be merged before v3 to prevent regressions since targetOrigin matters now

@velzie
velzie changed the base branch from main to develop September 25, 2026 16:18
@velzie
velzie force-pushed the feat/referer-fix-2 branch from e1cb7ea to 1f3119f Compare October 3, 2026 20:06
@velzie

velzie commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased this PR onto develop at 2e55e7d0 (#139). GitHub now reports it mergeable.

The new develop URL/base handling overlapped the referrer work, so I resolved the conflicts while retaining both behaviors. The rebase also exposed stale incumbent stack depths after develop changed interceptor dispatch. Commit 1f3119fe updates those depths; the PR's cross-origin postMessage/document.referrer test now passes.

Verification: core TypeScript check and all 220 core Vitest tests pass. The postmessage browser group has the same result before and after rebase (62 passed, 8 failed); its 5 unexpected failures reproduce on the original PR branch. The last full referrer run was before the stack-depth fix (146 passed, 10 failed); its one newly failing case passes in a focused rerun after the fix. The two other unexpected referrer failures (rv16-import-referrer and rv7-referrerpolicy-load) also reproduce on the original PR branch.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant