Quote plugin#115
Closed
JohnBee wants to merge 7 commits into
Closed
Conversation
JohnBee
commented
Oct 1, 2016
JohnBee
commented
- Moved to MongoDB
- Simpler interface only requiring nick to add and recall.
Added basic functionality, requires unit test
add quote now uses last message by person, get quote now uses nick
LordAro
reviewed
Oct 2, 2016
| raise self.QuoteError("No nick!") | ||
|
|
||
| quote = {} #output | ||
| quote["quote"] = last.last_message(nick)[2] |
Member
There was a problem hiding this comment.
I would be very surprised if this worked at all... Plugins aren't generally good at interacting with each other like that. Have you tested this?
| def _quoteExists(self, quote_post): | ||
| """Checks to see if a nick + quote already exists to stop repeats.""" | ||
| if self.db.find(quote_post).count > 0: | ||
| return True |
Member
There was a problem hiding this comment.
Come on, boolean logic please :)
| else: | ||
| return False | ||
|
|
||
| def _addquote(self, nick=""): |
Member
There was a problem hiding this comment.
Why use a default parameter if you just error on it anyway? Better to have a TypeError if you manage to call without a nick, imo
Member
|
Superseded by #123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.