Conversation
W3C HTML Validator raised the following issue ``` Error: Bad value true for attribute novalidate on element form. ``` This is because this component was rendering ``` <form novalidate="true"...> ``` When the newer syntax for boolean attributes is to reference the attribute alone ``` <form novalidate .....> ``` Signed-off-by: Alistair Laing <aliuk2012@users.noreply.github.com>
…nd hmpoTemplate components W3C HTML Validator raised the following information messgae about self-closing tags using trailing slash ``` Trailing slash on void elements has no effect and interacts badly with unquoted attribute values. ``` instead of ``` <link href="...." /> <input type="text" /> ``` the markup should be ``` <link href="...." > <input type="text" > ``` Signed-off-by: Alistair Laing <aliuk2012@users.noreply.github.com>
IE8 is no longer supported by govuk-frontend. I also searched references to `IE8`, `applicationStyleSheetIE8`, `applicationStyleSheet` and this was the only file that referenced IE8 Signed-off-by: Alistair Laing <aliuk2012@users.noreply.github.com>
marc-temp
approved these changes
Apr 17, 2026
Author
|
Any update on when this might be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best to review each commit separately.
Addresses a couple issues raised by W3C HTML Validator and removes mentions of IE8 and support for it as GOV.UK Frontend v5+ does not support IE let alone IE8 https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/browser-support.md#how-we-provide-support-for-different-browsers