Skip to content

feat: allow custom icon providers - #369

Merged
A7Lavinraj merged 2 commits into
FylerOrg:mainfrom
HundredBillion:feat/custom-icon-provider
Sep 23, 2026
Merged

A7Lavinraj merged 2 commits into
FylerOrg:mainfrom
HundredBillion:feat/custom-icon-provider

Conversation

@HundredBillion

@HundredBillion HundredBillion commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Allows integrations.icon to be a function in addition to the existing built-in provider names.\n\nThis enables image-backed integrations to reserve real buffer cells without relying on Fyler private rendering internals. Existing string providers are unchanged.\n\nTests: make tests (334 passing).

WHAT IS THIS FOR?

This will allow me to use my plugin with fyler so that I can see svg icons

BEFORE

Screenshot 2026-09-22 at 6 36 57 PM

AFTER

Screenshot 2026-09-22 at 6 38 21 PM

@A7Lavinraj

Copy link
Copy Markdown
Collaborator

@HundredBillion use make to check everything, format and lint.

@A7Lavinraj
A7Lavinraj merged commit e1626ff into FylerOrg:main Sep 23, 2026
5 checks passed
@A7Lavinraj

Copy link
Copy Markdown
Collaborator
image

@HundredBillion I assuming you'll be aware of this issue since you mark fyler adapter as experimental.

@HundredBillion

HundredBillion commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author
image @HundredBillion I assuming you'll be aware of this issue since you mark fyler adapter as experimental.

Ah thanks for finding this bug. I fixed it in svgtree and cut a new release. I recreated your directory and now it doesn't cut off the first 2 letters of the directory.

Thanks for merging in! fyler is really cool.

Screenshot 2026-09-23 at 10 13 54 AM

@HundredBillion
HundredBillion deleted the feat/custom-icon-provider branch September 23, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants