Conversation
|
Whats the point of the |
|
It is the Startup Window where you can select create new file, open file, etc. its just not complete yet. |
Also i will add things like recently opened files there later |
|
you guys were so right oop is so cool |
nevermind i got rid of it |
|
@not-nef need your insight on this review! #77 (comment) |
|
idk what you want me to look at, that hyperlink does nothing for me |
|
yeah i will change that in this pr, a lot needs to be redone in this repo |
|
most |
|
linux is really starting to grow on me but i cant switch because i wont be able to play most of my video games anymore :( |
|
you know what, im just gonna make a seperate windows partition for my games and switch to linux. |
|
my new motherboard should be arriving today so i am very excited. |
|
We gotta update the branch. |
|
@not-nef you added TkFileBrowser to the code. It's not there in |
|
yes, because i will most likely add more packages and will update requirements.txt before merging the branch |
|
Okay, so what about a Gitpod config? I need to add it just for configuring the image to load with VNC preview enabled. It uses Docker, so there would be an issue with that. |
|
We wouldn't need it much, yes, but if anybody were to test on the fly, it might help. I'm not coding anything on my local computer since Zorin and Python seem to be at odds right now. |
|
so the app is lagging like crazy, but the tkfilebrowser instance inside of it is running smooth as ever. something is clearly not right |
|
So, it isn't working on Gitpod. Asciinema(basically fancy terminal video) clip: |
|
manually set |
|
Will do so later, thanks! |
|
It seems to be rapid for me, apart from the lag you get from noVNC. @not-nef try this, exactly as I say. |
|
Save functions aren't working though, maybe a bug. How do we save it in the first place? |
You think its the filebrowser module? |
wdym how do we save it? where the function is? |
Usually, we have a save button, or at least a shortcut. Neither exists in that, as well as I can't go through folders yet.
Well, that gives a save issue for me, but I think it could be some module that just keeps reloading or something, but is building up the data, piling it up. Maybe that could be the reason behind the lag? I don't know. |
It is in the menu at the top of the screen
i need to further investigate |
|
There isn't a save button in the Save As UI. Like the button we have on Windows for saving. It could also be due to Xfce. |
|
finally found some time to code again. im definitely not bugging. i got the main branch to sort of run and it is blazing fast as usual. that means theres got to be something wrong with my code. time to dig |
|
i am 99% sure its an issue with sv_ttk because if i comment out the line that sets the theme, everything is fast as usual |
|
I think you might have kept something weird with the theme part. Check that out, it might give some insight, since that could easily cause lag. |
|
i dont know what you mean |
|
I didn't explain. Maybe you set up an auto-detection for the system theme, but it kinda loops over and over again, making new processes I guess. Could be something similar.:shrug: |
|
i didnt set up theme detection yet |
|
I thought you did. My bad, I got confused. Maybe the theme code is sort of just running on a loop? |
|
I know it's selective, but maybe it is running that continuously. |
|
|
but why is the version before the rewrite so fast? |
|
Yeah, that's strange. Are you using a type of widget in the new version that you weren't before? |
|
not that i could think of, but everything is oop now |
That shouldn't cause slowness |
4 participants
complete rewrite from the ground up with oop and good this time
help much appreciated
why is the file diff so ducked up