Skip to content

Bump System.Security.Cryptography.Xml to the advisory-patched versions#532

Merged
ITaluone merged 1 commit into
Fallout-build:mainfrom
lahma:security/crypto-xml-advisory-bump
Jul 23, 2026
Merged

Bump System.Security.Cryptography.Xml to the advisory-patched versions#532
ITaluone merged 1 commit into
Fallout-build:mainfrom
lahma:security/crypto-xml-advisory-bump

Conversation

@lahma

@lahma lahma commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

System.Security.Cryptography.Xml is pinned at versions inside the affected range of five high-severity advisories — uncontrolled resource consumption during XML decryption (CVSS 7.5):

Each line moves to its first patched release:

TFM Before After
net10.0 10.0.6 10.0.10
net9.0 9.0.15 9.0.18
net8.0 8.0.3 8.0.4

Fallout.Common declares the package as a direct dependency, so consumers inherit the vulnerable version transitively and NuGetAudit fires on their build project — the only fix on their side is a local pin. Migrating Quartz.NET off NUKE surfaced this; it currently has to carry:

<PackageReference Include="System.Security.Cryptography.Xml" Version="10.0.10" />

Both the central version list and build/_build.csproj are bumped — the build project turns off central package management, so its inline pin is separate.

dotnet restore fallout.slnx is clean for every src/ project afterwards. tests/Consumers/Fallout.Consumer.NuGet still warns because it resolves the published Fallout.Common from nuget.org; that clears once a release ships with this bump.

🤖 Generated with Claude Code

10.0.6, 9.0.15 and 8.0.3 are all inside the affected ranges of five high-severity
advisories (GHSA-23rf-6693-g89p, GHSA-8q5v-6pqq-x66h, GHSA-cvvh-rhrc-wg4q,
GHSA-g8r8-53c2-pm3f, GHSA-mmjf-rqrv-855v) — uncontrolled resource consumption in
XML decryption. Move each line to its first patched release: 10.0.10, 9.0.18, 8.0.4.

Fallout.Common carries the package as a direct dependency, so every consumer
inherits the vulnerable version transitively and has to pin around it locally.

Both the central version list and build/_build.csproj are bumped; the build
project turns off central package management, so its inline pin is separate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@ITaluone ITaluone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

And: welcome to the repo 😄

@ChrisonSimtian ChrisonSimtian added the target/vCurrent Targets the current version label Jul 23, 2026
@ITaluone
ITaluone merged commit bd6471b into Fallout-build:main Jul 23, 2026
1 check passed
@lahma
lahma deleted the security/crypto-xml-advisory-bump branch July 23, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target/vCurrent Targets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants