[1.21] Fixed & extended MishapInternalException - #1259
Closed
YukkuriC wants to merge 1 commit into
Closed
Conversation
object-Object
approved these changes
Aug 15, 2026
object-Object
left a comment
object-Object
left a comment
Member
There was a problem hiding this comment.
LGTM, but is there a particular reason this has to be for 1.21, or could it be merged into main instead so we can have this on 1.20 as well?
Contributor
Author
yes it could, the primary reason for this PR is the kicking issue, and the stacktrace part is "we have to do manual toString anyway so why not" :3 |
YukkuriC
changed the title
Member
|
Do we need to also merge this one, or is it ok to close this and merge #1268 into 1.21 in a main to next bundle? |
Contributor
Author
both ok for me :3 |
hexxy-weblate
pushed a commit
to hexxy-weblate/HexMod
that referenced
this pull request
Aug 16, 2026
FallingColors#1259, but for branch main > ~~fixes FallingColors#1229~~ > ~~and~~ adds detailed stacktrace (hover + click copy) for its debugging purpose > <img width="474" height="182" alt="image" src="https://github.com/user-attachments/assets/67df25c7-a6a0-462f-9c92-900dcfe55fd7" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1229
and adds detailed stacktrace (hover + click copy) for its debugging purpose
