Skip to content

[Snyk] Security upgrade shell-quote from 1.8.3 to 1.8.4#89

Open
factory-service-snyk wants to merge 1 commit into
devfrom
snyk-fix-8a4a6728563cd61e73657a883c541743
Open

[Snyk] Security upgrade shell-quote from 1.8.3 to 1.8.4#89
factory-service-snyk wants to merge 1 commit into
devfrom
snyk-fix-8a4a6728563cd61e73657a883c541743

Conversation

@factory-service-snyk
Copy link
Copy Markdown

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
⚠️ Warning
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Arbitrary Command Injection
SNYK-JS-SHELLQUOTE-16799355
  735  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Arbitrary Command Injection

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SHELLQUOTE-16799355
@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid Bot commented May 27, 2026

Droid finished @factory-service-snyk's task —— View job


Security Review

Droid is reviewing code and running a security check…


Review summary: The dependency bump is straightforward, but it’s currently incomplete: the root lockfiles still pin shell-quote@1.8.3, and the separately-installed base-action still depends on 1.8.3. Update the relevant lockfiles and bump base-action to ensure 1.8.4 is what’s installed in CI/runtime.

Comment thread package.json
"@octokit/rest": "^21.1.1",
"@octokit/webhooks-types": "^7.6.1",
"shell-quote": "^1.8.3",
"shell-quote": "^1.8.4",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Update lockfiles to match shell-quote bump

package.json now requires shell-quote: ^1.8.4, but both lockfiles still pin/reference shell-quote@1.8.3 (bun.lock and package-lock.json), and this repo’s composite actions run bun install (e.g. action.yml, base-action/action.yml), so installs will drift/rewrite during runs and scanners may continue flagging 1.8.3 until the lockfiles are regenerated/updated.

Comment thread package.json
"@octokit/rest": "^21.1.1",
"@octokit/webhooks-types": "^7.6.1",
"shell-quote": "^1.8.3",
"shell-quote": "^1.8.4",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] [security] Also bump shell-quote in base-action to fully remediate

The root dependency bump won’t remove the vulnerable shell-quote@1.8.3 from all execution paths because base-action/package.json (and its lockfiles) still depend on shell-quote: ^1.8.3, and the composite workflows explicitly bun install the base-action separately; bumping only the root package can therefore leave SNYK-JS-SHELLQUOTE-16799355 present at runtime unless base-action is upgraded too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants