[Snyk] Security upgrade shell-quote from 1.8.3 to 1.8.4#89
[Snyk] Security upgrade shell-quote from 1.8.3 to 1.8.4#89factory-service-snyk wants to merge 1 commit into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SHELLQUOTE-16799355
|
Droid finished @factory-service-snyk's task —— View job Droid is reviewing code and running a security check… Review summary: The dependency bump is straightforward, but it’s currently incomplete: the root lockfiles still pin |
| "@octokit/rest": "^21.1.1", | ||
| "@octokit/webhooks-types": "^7.6.1", | ||
| "shell-quote": "^1.8.3", | ||
| "shell-quote": "^1.8.4", |
There was a problem hiding this comment.
[P1] Update lockfiles to match shell-quote bump
package.json now requires shell-quote: ^1.8.4, but both lockfiles still pin/reference shell-quote@1.8.3 (bun.lock and package-lock.json), and this repo’s composite actions run bun install (e.g. action.yml, base-action/action.yml), so installs will drift/rewrite during runs and scanners may continue flagging 1.8.3 until the lockfiles are regenerated/updated.
| "@octokit/rest": "^21.1.1", | ||
| "@octokit/webhooks-types": "^7.6.1", | ||
| "shell-quote": "^1.8.3", | ||
| "shell-quote": "^1.8.4", |
There was a problem hiding this comment.
[P1] [security] Also bump shell-quote in base-action to fully remediate
The root dependency bump won’t remove the vulnerable shell-quote@1.8.3 from all execution paths because base-action/package.json (and its lockfiles) still depend on shell-quote: ^1.8.3, and the composite workflows explicitly bun install the base-action separately; bumping only the root package can therefore leave SNYK-JS-SHELLQUOTE-16799355 present at runtime unless base-action is upgraded too.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-SHELLQUOTE-16799355
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Arbitrary Command Injection