Skip to content

Add Mirror testing - #1167

Draft
fantomitechno wants to merge 2 commits into
EverestAPI:devfrom
fantomitechno:dev
Draft

Add Mirror testing#1167
fantomitechno wants to merge 2 commits into
EverestAPI:devfrom
fantomitechno:dev

Conversation

@fantomitechno

Copy link
Copy Markdown

This PR allows to have an automated system, downloading a test mod from all sources and comparing the speed, choosing the fastest one

2026-08-29.21-04-50.mp4

Why is this a draft?

  1. I hardcoded the testing mod (it is the latest version of Maddie's Helping Hand, (link) as of speaking), it would need something else to test, but I do not know what (maybe thinking provided by an API as for the mod dependencies graph and other, or a specific test mod uploaded for this purpose only)
  2. I am not entirely sure my way of doing the screen to display test result is correct

Also I have an issue with how I use my results, I think it could be interesting to have the resulting config be top1,top2,top3,top4,... but as of now, how the Mirror settings work, I need to follow the by region order that are already provided:

List<string> mirrorPreferences = new List<string> {
    "gb,jade,risingsunlight,otobot,wegfan",
    "jade,risingsunlight,otobot,wegfan,gb",
    "wegfan,otobot,jade,risingsunlight,gb",
    "otobot,jade,risingsunlight,wegfan,gb",
    "risingsunlight,jade,otobot,wegfan,gb"
}

I can still save a custom list but it would be displayed as Disabled in the settings:
image

Also, I use the "MODOPTIONS_COREMODULE_MIRRORPREFERENCES_{mirror_name}" to display the name except for GameBanana which I hardcoded as GameBanana (I don't know if I should have used a new translation key as the already existing says Disabled, which make sens in the context of the Mirror Preference setting, but also you can translate country/part of the world, but GB is not translatable?)

string mirrorName = Dialog.Clean("MODOPTIONS_COREMODULE_MIRRORPREFERENCES_" + mirrorNames[mirrorIndex]);
if (mirrorNames[mirrorIndex] == "gb") {
    mirrorName = "GameBanana";
}

@maddie480-bot maddie480-bot added the 0: draft This PR is not ready for review yet (bot-managed) label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0: draft This PR is not ready for review yet (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants