Fix CassetteListener.EntityAdded to use Level.ShouldCreateCassetteManager - #1162
Open
aonkeeper4 wants to merge 1 commit into
Open
Fix CassetteListener.EntityAdded to use Level.ShouldCreateCassetteManager#1162aonkeeper4 wants to merge 1 commit into
CassetteListener.EntityAdded to use Level.ShouldCreateCassetteManager#1162aonkeeper4 wants to merge 1 commit into
Conversation
maddie480-bot
added
the
1: review needed
microlith57
approved these changes
Aug 22, 2026
Comment on lines
+49
to
+52
| // we want to expose `ShouldCreateCassetteManager` to `CassetteListener` without modifying its visibility, so create an internal property that forwards to it | ||
| [MonoModIgnore] | ||
| private bool ShouldCreateCassetteManager { get; } | ||
| internal bool _ShouldCreateCassetteManager => ShouldCreateCassetteManager; |
Member
There was a problem hiding this comment.
why not just. make it public?
Contributor
Author
There was a problem hiding this comment.
people hook it manually :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
CassetteListener.EntityAddeduseLevel.ShouldCreateCassetteManagerdirectly when checking whether to add aCassetteBlockManager, instead of duplicating the logic. This makes mods hookingShouldCreateCassetteManager(e.g. custom cassette blocks, most notably Quantum Mechanics' wonky cassette blocks) work properly with cassette listeners, as previously this would have required a hook into Everest.