Repository navigation
Fix symlinks on unsupported filesystems on OSes other than Windows - #1159
Draft
SnipUndercover wants to merge 4 commits into
Draft
SnipUndercover wants to merge 4 commits into
SnipUndercover wants to merge 4 commits into
Conversation
microlith57
reviewed
Aug 9, 2026
Contributor
|
I tested the changes on Linux, and as far as I can tell it works properly on my end:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, installing Everest to a drive with a filesystem that does not support symlinks (like FAT32, exFAT, and others) will crash MiniInstaller completely, instead of falling back to copying the file.
Normally Windows would have shown a message box for this case, but neither Linux or macOS had fallback mechanisms for that.
This PR adds the prompt to other filesystems, leveraging SDL2's
SDL_ShowMessageBoxAPI that's cross-compatible. Might as well use the SDL2 we ship, right?It will fall back to copying files if the user chooses to proceed, and will exit early if the user chooses to cancel.
Furthermore, the elevation prompt has also been changed to use SDL's API.
Keeping as draft until all OSes have been tested following the TODO list below.
Note
Most of the daunting +9300 additions are caused by a copy-paste of
EverestSplash's SDL bindings.TODOs