Fix/asciipietpp#19
Merged
Merged
Conversation
… update documentation and tests
# Conflicts: # Generator/MethodGenerator.cs # Interpreter.Tests/ProgramTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the ascii-piet++ parser and related documentation to support both
|and@as row separators, and updates analyzers and test code for consistency and clarity. The most important changes are summarized below.Ascii-piet++ parser and documentation improvements:
AsciiPietPlusPlusParser) now recognizes both|and@as valid row separator markers, ignoring actual newline characters. This is reflected in the parser logic, documentation comments, and help text. [1] [2] [3] [4] [5]|and@are accepted as row separators and that detection logic (LooksLikeAsciiPietPlusPlus) works with either marker. [1] [2]Interpreter and CLI updates:
|and@as supported row-separator characters. [1] [2]@row separator.Code consistency and cleanup:
LanguageTypealias instead of the fully qualifiedEsolang.Piet.Parser.LanguageTypeinMethodGenerator.csfor clarity and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]Analyzer and configuration updates:
.editorconfigto add or adjust analyzer rules (IDE0001, IDE0002, IDE0130), set accessibility modifier preferences, and remove MSTest-specific analyzer settings. [1] [2] [3]Test code modernization:
PietMethodGeneratorTests.cs. [1] [2] [3] [4]