Skip to content

Fix/asciipietpp#19

Merged
juner merged 3 commits into
mainfrom
fix/asciipietpp
Jul 15, 2026
Merged

Fix/asciipietpp#19
juner merged 3 commits into
mainfrom
fix/asciipietpp

Conversation

@juner

@juner juner commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This pull request improves the ascii-piet++ parser and related documentation to support both | and @ as row separators, and updates analyzers and test code for consistency and clarity. The most important changes are summarized below.

Ascii-piet++ parser and documentation improvements:

  • The ascii-piet++ parser (AsciiPietPlusPlusParser) now recognizes both | and @ as valid row separator markers, ignoring actual newline characters. This is reflected in the parser logic, documentation comments, and help text. [1] [2] [3] [4] [5]
  • Added and updated tests to verify that both | and @ are accepted as row separators and that detection logic (LooksLikeAsciiPietPlusPlus) works with either marker. [1] [2]

Interpreter and CLI updates:

  • The ascii-piet++ color table/help text now documents both | and @ as supported row-separator characters. [1] [2]
  • Added an integration test to ensure the CLI correctly handles ascii-piet++ text input using the alternate @ row separator.

Code consistency and cleanup:

  • Refactored code to consistently use the LanguageType alias instead of the fully qualified Esolang.Piet.Parser.LanguageType in MethodGenerator.cs for clarity and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]

Analyzer and configuration updates:

  • Updated .editorconfig to add or adjust analyzer rules (IDE0001, IDE0002, IDE0130), set accessibility modifier preferences, and remove MSTest-specific analyzer settings. [1] [2] [3]

Test code modernization:

  • Cleaned up test code to use simplified type names and improved instance creation patterns in PietMethodGeneratorTests.cs. [1] [2] [3] [4]

juner added 3 commits July 2, 2026 21:42
# Conflicts:
#	Generator/MethodGenerator.cs
#	Interpreter.Tests/ProgramTests.cs
@juner
juner merged commit e795493 into main Jul 15, 2026
11 checks passed
@juner
juner deleted the fix/asciipietpp branch July 15, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant