Skip to content

Make model identifier (version code) string public #45

Open

Description

@tadija

Hi @Ekhoo, thanks for this library, I like it and use it often.

Sometimes model identifier is used in a "raw" value (i.e. "iPhone9,4"), for instance when sending client device information to a backend or similar, but in current version of Device this info is hidden behind static fileprivate func getVersionCode() -> String. Would you mind making that public?

Also, is there a particular reason for all of these version, size, type to be static methods instead of static properties? To me it seems a little bit more convenient if those were just properties instead of methods... What do you think?

Cheers,
// T

Activity

  1. zhuangxq commented on May 25, 2020

    @zhuangxq

    same issue, I also need getVersionCode to be public.

  2. kishorepran commented on Oct 21, 2026

    @kishorepran
    Collaborator

    @tadija / @zhuangxq : if this is still relevant please raise a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions