Skip to content

bug: config include recursion blocks valid DAG configurations #11

Closed

Description

@EffortlessSteven

Problem

config_loader.rs uses a global HashSet<PathBuf> to detect circular includes. This treats any repeated include as a cycle, blocking valid DAG configurations like:

main → {team-a, team-b} → shared-base

When shared-base is reached the second time through team-b, it's falsely reported as a "Circular include".

Fix

Track the current include stack (ancestor chain) for cycle detection, not a global visited set. Allow the same file to be included multiple times as long as it's not in the current ancestor chain.

Alternatively, cache successful loads and reuse them (like a memoized loader).

Source

PR #5 review — Codex P1 (comment #1).

Activity

  1. added a commit that references this issue on Apr 5, 2026
    77f27e1
  2. EffortlessSteven commented on Apr 5, 2026

    @EffortlessSteven
    MemberAuthor

    Fixed in PR #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions