Add DFX fiat ramp provider#6061
Open
j0ntz wants to merge 2 commits into
Open
Conversation
Contributor
Author
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fc8ddf3. Configure here.
fc8ddf3 to
a096719
Compare
Integrate DFX (app.dfx.swiss) as a SEPA-based buy/sell fiat ramp using the external ramp webview pattern. Registers the dfx ramp plugin, adds its GUI plugin entry and env init option, and supports EUR/CHF across the SEPA region plus Switzerland and Liechtenstein for BTC, ETH and major EVM chains, Solana and Monero.
Add testIDs to the fiat and crypto dropdown buttons in the ramp create scene so UI tests can drive the fiat/crypto selectors by id.
a096719 to
ee8d927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Integrate DFX (API, docs) as a new SEPA fiat buy/sell ramp (no swap), using the new
src/plugins/ramps/external-ramp pattern (same shape asbitsofgold/libertyx): no quoting API, the user is deeplinked into the DFX web widget to complete the buy/sell.What this adds:
src/plugins/ramps/dfx/dfxRampPlugin.tsanddfxRampTypes.ts— the DFX external ramp factory plus its init-options cleaner.dfxinallRampPlugins.ts.dfxGUI plugin (baseUri: https://app.dfx.swiss, camera permission for QR scanning) and wiresdfxintoRAMP_PLUGIN_INITSinenvConfig.ts(defaultundefined, i.e. off until enabled via env/info-server).Support matrix:
sepapayment type, EUR/CHF, SEPA region plus Switzerland and Liechtenstein, for Bitcoin, Ethereum, Arbitrum, Optimism, Polygon, Base, BNB Smart Chain, Solana and Monero; buy →/buy, sell →/sell.A second commit adds
testIDs to the ramp create scene's fiat/crypto dropdown buttons so UI tests can drive the selectors by id.Testing: drove the Buy flow on the iOS simulator with region Germany / fiat EUR / Bitcoin. DFX surfaces as the "SEPA Bank Transfer" payment method ("Powered By: DFX", settlement 1-3 days), and selecting it opens the DFX web widget (
app.dfx.swiss). Screenshots attached.tsc --noEmit, eslint and the jest suite pass.Asana task
Note
Low Risk
New optional ramp provider behind env init config; no changes to auth, payments, or existing ramp quoting flows beyond registration and UI test hooks.
Overview
Adds DFX as a new SEPA fiat buy/sell ramp using the same external-ramp pattern as Bits of Gold and LibertyX: no in-app quoting; users are deeplinked into the DFX web widget at
https://app.dfx.swiss(/buyor/sell).Wiring includes a new
dfxGUI plugin (camera permission for QR), registration inallRampPlugins.ts, and optionalRAMP_PLUGIN_INITS.dfxinenvConfig.ts(off until enabled via env/info-server). Support is SEPA for EUR/CHF in SEPA countries plus CH/LI, with settlement 1–3 days, for BTC, ETH, several EVM L2s, BSC, Solana, and Monero. Init options allowpartnerIconand awalletidentifier for white-label builds.Also adds
testIDsrampFiatDropdownandrampCryptoDropdownonRampCreateScenedropdown buttons for UI automation.Reviewed by Cursor Bugbot for commit ee8d927. Bugbot is set up for automated code reviews on this repo. Configure here.