Use GridLaneLayout - #246
Open
Ghabry wants to merge 5 commits into
Open
Conversation
Some adjustments (see comments) are required to make it work better for us. Main issue is that it forces the components to be quite small by default and overwriting this requires dummy elements that force a width which isn't really better...
A Grid Lane Layout (or Masonry Layout) is similar to a Grid Layout but with the difference that for each column the gaps are filled This makes the layout nicely reponsive and we need a responsive design as th editor has usually a lot of data to configure per page. Adopt this Grid Lane Layout for the Actor and the Attribute Page
Still not ideal but better than before...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was discussing with jetrotal a while ago how to make the editor more "responsive" without making it look like a mobile app.
What we came up with is using a Grid Lane Layout which automatically moves Tiles (I call it Card to match Kirigami) around based on the window width. So it shows more tiles per line depending on the Window/Screen Width.
The Grid Lane Layout (or Masonry Layout) itself was mostly AI generated (I added the doc comments) and I couldn't find any prior work regarding this in QML. At least it looks like it works and is only about 80 lines.
Also had to vendor the FormLayout as it hardcodes some width and padding which is inconvenient for us as this stuff was too small (and felt mobile first). As an alternative I can provide AI-generated monkey-patching of the original FormLayout but the code was so bad that I consider vendoring the cleaner way here...
Bildschirmaufnahme_20260904_124712.mp4
For the lulz: This happens when you tell Spectacle to record a Window and then resize it while recording xD
Bildschirmaufnahme_20260904_124603.mp4