Skip to content

Add per-workbook RenderContext on ExcelWorkbook #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanKallman merged 6 commits into from
Jun 30, 2026
Merged

Add per-workbook RenderContext on ExcelWorkbook #2395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d14074
Work in progress: removing calls to static methods to OpenTypeFonts d…
swmal Jun 25, 2026
80c92b5
Replace global font singleton with per-workbook RenderContext in rend…
Jun 26, 2026
91b9b3f
Add per-workbook RenderContext on ExcelWorkbook and thread it through…
swmal Jun 29, 2026
e0dede7
Merged ShapeToSvgTests
swmal Jun 30, 2026
4f86029
Merge branch 'develop9' into feature/VariableFontsV1
swmal Jun 30, 2026
1bc0223
Added tests for ConfigureFonts
swmal Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EPPlus.DrawingRenderer.Tests/Chart/LineChartToSvgTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public void GenerateSvgForLineCharts()
}

[TestMethod]
public void GenerateSvgForCharts_SecondaryAxis()
public void GenerateSuperScript()
{
ExcelPackage.License.SetNonCommercialOrganization("EPPlus Project");
using (var p = OpenTemplatePackage("ChartForSvg_SecondaryAxis.xlsx"))
Expand Down
9 changes: 7 additions & 2 deletions src/EPPlus.DrawingRenderer.Tests/DrawingShapeRenderer/SvgStandAloneTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using EPPlus.DrawingRenderer.RenderItems.SvgItem;
using EPPlus.DrawingRenderer.Svg;
using EPPlus.Export.ImageRenderer.RenderItems.SvgItem;
using EPPlus.Fonts.OpenType;
using EPPlus.Fonts.OpenType.Integration.DataHolders;
using EPPlus.Graphics;
using System.Drawing;
Expand Down Expand Up @@ -120,7 +121,9 @@ private void GenerateTextBodyFile(string fileName, GroupRenderItem baseGroup, Sv

private SvgTextBodyRenderItem GenerateTextBody(GroupRenderItem baseGroup)
{
var textBody = new SvgTextBodyRenderItem(baseGroup.Bounds, true);
var engine = new OpenTypeFontEngine(x => x.SearchSystemDirectories = true);
var renderContext = new RenderContext(() => engine);
var textBody = new SvgTextBodyRenderItem(renderContext, baseGroup.Bounds, true);
var paragraph = textBody.AddParagraph("Hello");

paragraph.AddText(" There");
Expand Down Expand Up @@ -271,7 +274,9 @@ private RenderTextbox GenerateTextBox(out GroupRenderItem group)
group = GenerateGroupRenderItem();

var textbox = new RenderTextbox(group.Bounds, 500d, 500d);
textbox.TextBody = new SvgTextBodyRenderItem(group.Bounds, true);
var engine = new OpenTypeFontEngine(x => x.SearchSystemDirectories = true);
var rc = new RenderContext(() => engine);
textbox.TextBody = new SvgTextBodyRenderItem(rc, group.Bounds, true);
var paragraph = textbox.TextBody.AddParagraph("Hello");

paragraph.AddText(" There");
Expand Down
Loading
Loading