feat(commands): Add support for Range[LargeInt, ...]#1201
Merged
Conversation
Enegg
changed the title
Range[LargeInt, ...]Range[LargeInt, ...]
8 tasks
|
|
Contributor
Author
|
Tangentially related: we could add slice support for defining ranges ( |
Enegg
commented
Nov 14, 2024
Member
|
Hi, would you please resolve conflicts? |
Enegg
force-pushed
the
Eneg/large-range
branch
from
5fff87a to
dddeb46
Compare
Enegg
force-pushed
the
Eneg/large-range
branch
from
5410c06 to
57f7855
Compare
shiftinv
reviewed
Nov 19, 2025
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Eneg <42005170+Enegg@users.noreply.github.com>
…nto Eneg/large-range
shiftinv
reviewed
Jun 28, 2026
Signed-off-by: vi <8530778+shiftinv@users.noreply.github.com>
This isn't immediately an issue, but prevents this documenter from being used for members that are classes (for whatever reason that would be the case). We only want to use it if explicitly specified through `autoclassalias::`
shiftinv
reviewed
Jun 28, 2026
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Eneg <42005170+Enegg@users.noreply.github.com>
Add extra tests
shiftinv
reviewed
Jun 29, 2026
shiftinv
approved these changes
Jul 4, 2026
shiftinv
left a comment
shiftinv
left a comment
Member
There was a problem hiding this comment.
lgtm! Thank you for all your work on this feature (and patience), really appreciate it c:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #787
This PR adds support for defining a range of accepted values for
commands.LargeInt.If both bounds are specified, we restrict the length of the string input according to the number of digits (and sign) of the bounds.
We also raise an error during conversion, if the provided value would exceed the defined range (for example
Range[LargeInt, 100, 200]would have actual possible input of 100-999).I've also implemented a check in case the developer attempts to define a range exceeding ±2**53 with the normal
inttype, directing them toLargeInt.Checklist
pdm lintpdm pyright