Whole-suite history chart: subtract /encoding/ from the run totals - #26
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'DevinAI' or '@devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
/wpt?range=allbrowser lines went to ~200%: the whole-suite union total from the comparison DB (~1.12M subtests) leaves out/encoding/(which the ingester skips as very large and not layout-relevant), but browser-wpt-results'total.jsoncounts it (~1.15M subtests on its own), so passed counts exceeded the denominator.Fix: the whole-suite history is now
total.json − areas/encoding.jsonper run, so it covers the same tests as the DB total it is divided by.Sanity check with current data: Chrome 2,269,986 − 1,152,348 = 1,117,638 vs DB union total 1,119,347 → 99.8%.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/6a70291c2fd54da1a02968bb80f8622b
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/6a70291c2fd54da1a02968bb80f8622b?variant=devin-insiders
Requested by: @nicoburns