Skip to content
This repository was archived by the owner on Mar 13, 2024. It is now read-only.
This repository was archived by the owner on Mar 13, 2024. It is now read-only.

Is there any benefit in generating _version.py? #123

Description

@coretl

In #81 @garryod changed to get __version__ from importlib.metadata:

from importlib.metadata import version
__version__ = version("python3-pip-skeleton")

This means that we require the module to be installed so we know the version. This means that _version.py is not used, ever. We can clean up here, and stop generating it:

[tool.setuptools_scm]
write_to = "src/python3_pip_skeleton/_version.py"

and ignoring it:
**/_version.py

@garryod @GDYendell @gilesknap @AlexanderWells-diamond: any reason we should not do this?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions