[socketcluster-server] fix v14 types

[MegaGM]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. - Not required for this fix.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: fix socket.kickOut() v14 SocketCluster/socketcluster-server#50
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@MegaGM Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• socketcluster-server — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 64279,
  "author": "MegaGM",
  "headCommitOid": "2f835bff2589d8972b8dcc38da90be8e89619417",
  "mergeBaseOid": "29e78e018dc6c7d49f7bb101064da9163f7f8cf5",
  "lastPushDate": "2023-02-08T16:37:54.000Z",
  "lastActivityDate": "2023-02-26T19:17:51.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "socketcluster-server",
      "kind": "edit",
      "files": [
        {
          "path": "types/socketcluster-server/v14/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/socketcluster-server/v14/scserversocket.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "DanielRose",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "Methuselah96",
      "date": "2023-02-26T19:17:51.000Z"
    }
  ],
  "mainBotCommentID": 1422944014,
  "ciResult": "pass"
}

[typescript-bot]

Hey @MegaGM,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @DanielRose @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[DanielRose]

Thanks for the update. However, currently the commit (SocketCluster/socketcluster-server@ffb126c) is not yet of a released npm version. The newest version on npm is 14.7.2, from June 2021, which does not contain the change. As soon as a version is released, this can merged.

[typescript-bot]

Re-ping @DanielRose, @Methuselah96:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @MegaGM.

(Ping @DanielRose, @Methuselah96.)

[Methuselah96]

Still waiting on this change actually being released.

[typescript-bot]

@MegaGM One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@MegaGM I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Mar 28th (in a week) if the issues aren't addressed.

[typescript-bot]

@MegaGM To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!