Use canonical FFE fixtures#11355
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 057cdefcb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return ProviderEvaluation.<T>builder() | ||
| .value(defaultValue) | ||
| .reason(Reason.DEFAULT.name()) | ||
| .build(); |
There was a problem hiding this comment.
Restore missing-flag error reporting
When a configured provider is asked for a flag key that is absent from config.flags, this now returns a normal DEFAULT evaluation with no FLAG_NOT_FOUND error. In that scenario OpenFeature callers and the existing FlagEvalHook metrics path will report the lookup as a successful default rather than a missing-flag error, so dashboards/alerts that depend on error.type=flag_not_found stop seeing these failures. If the intent is only to return the supplied default value, keep that value but preserve the error reason/code for absent flags.
Useful? React with 👍 / 👎.
Motivation
Make
DataDog/ffe-system-test-datathe canonical source for FFE/OpenFeature JSON fixtures in dd-trace-java. This removes copied smoke-test fixtures and moves evaluator behavior coverage to the shared corpus. Depends on DataDog/ffe-system-test-data#9.Changes
dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-dataas a git submodule pinned to the canonical fixture update.ufc-config.jsonand all sortedevaluation-cases/*.jsonfiles.gitsubmoduleupdates.📖 https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/6713639211/FFE+SDK+Fixture+Contribution+Guide
Decisions
ffe-system-test-data, not programmatic or copied fixture sets.Validation
JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./gradlew :dd-smoke-tests:openfeature:codenarcTestJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./gradlew :products:feature-flagging:feature-flagging-api:test --tests datadog.trace.api.openfeature.DDEvaluatorTest