Fix the behaviour of asynchronous counters and up-down counters#11332
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 12, 2026
Merged
Conversation
mcculls
added
type: bug
5 tasks
mcculls
force-pushed
the
mcculls/fix-otel-async-counter-behaviour
branch
3 times, most recently
from
fe56ec1 to
d8b110a
Compare
Unlike synchronous counters which take the increment/delta value, asynchronous callbacks report the absolute value of the counter.
mcculls
force-pushed
the
mcculls/fix-otel-async-counter-behaviour
branch
from
d8b110a to
7951fb3
Compare
mhlidd
approved these changes
May 12, 2026
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
mcculls/fix-otel-async-counter-behaviour
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Switches the underlying storage for asynchronous counters and up-down counters to expect absolute values from the callback, as per the spec.
Motivation
Unlike synchronous counters which maintain a sum, asynchronous callbacks record the absolute value of the counter and then report that value or a delta depending on the temporality preference:
https://opentelemetry.io/docs/specs/otel/metrics/api/#asynchronous-counter-creation
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-1937
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.