feat: Normalize all "targethost" and hex-encoded fields - #4944
Merged
Merged
Conversation
TomOnTime
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Not all fields are normalized (changed to lowercase) so that future comparisons do not need to be case aware.
This issue was fixed for CNAME in #4940 but other record fields, such as the MX record's Mx, are not normalized.
Tracking which record type fields need to be normalized is a PITA.
Resolution
Create a function
normalizeRDATA()which normalizes fields. The function will be code-generated so that future rtypes will be properly normalized.While we're at it, let's normalize hex data to lowercase instead of uppercase like the rest of the world does.