Set serviceUrl via setClientOptions#473
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables updating the API serviceUrl after client instantiation via setClientOptions, keeping URL normalization behavior consistent with the constructor (HTTPS enforcement by default, trailing-slash stripping, and respecting allowHttpServiceUrl).
Changes:
- Persist
allowHttpServiceUrlontothis.optionssosetClientOptionscan normalizeserviceUrlconsistently. - Add
serviceUrlsupport tosetClientOptionsand extend unit tests to cover update/normalization behavior. - Update
cspell.jsondictionary entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/constructorio.js | Add serviceUrl handling to setClientOptions and persist allowHttpServiceUrl in runtime options. |
| spec/src/constructorio.js | Add test coverage for updating and normalizing serviceUrl via setClientOptions. |
| cspell.json | Add/adjust dictionary words. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![constructor-claude-bedrock[bot]](https://avatars.githubusercontent.com/u/9828194?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Mudaafi
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.