[CSL-3045] Added enforcement of https for service client url#309
Conversation
esezen
left a comment
esezen
left a comment
There was a problem hiding this comment.
Left one comment about the test. The rest is looking good!
| expect(instance.options).to.have.property('networkParameters').to.equal(networkParameters); | ||
| }); | ||
|
|
||
| it('Should return an instance with correct serviceUrl when a http serviceUrl is passed', () => { |
There was a problem hiding this comment.
The description says http serviceUrl is passed but we are passing an https value on line 87. Can we update the test to have an http value there.
Also it might be nice to drop the other parameters and make it more similar to this test so it's clear what's being tested here
There was a problem hiding this comment.
should be taken care of, thanks for pointing it out.
|
Hi! Would you approve adding an option to disable this "force https" feature? I have implemented a "fake Constructor" in our java backend so we can prototype changes to our catalog updates on our local machines without having to actually upload the catalog to a Constructor index. If not, we'll have keep using a fork of this repo, which would mean added maintenance work and delayed updates for the client library. Nevertheless it is net beneficial for us by letting us develop our Constructor experience in an agile manner. |
|
Welp, here it is anyway.. #460 |
3 participants
This PR enforces HTTPs for the Service Url, similarly to what was done for the Node client in this PR