Skip to content

Replace PaperSecret bridge with generated SDK#148

Merged
pquerna merged 1 commit into
mainfrom
paul.querna/CONE-147/replace-papersecret-bridge
Jul 20, 2026
Merged

Replace PaperSecret bridge with generated SDK#148
pquerna merged 1 commit into
mainfrom
paul.querna/CONE-147/replace-papersecret-bridge

Conversation

@c1-squire-dev

@c1-squire-dev c1-squire-dev Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pin github.com/conductorone/conductorone-sdk-go v1.29.0 and regenerate the vendored dependency tree
  • replace the temporary raw internal/external PaperSecret create bridge with generated SDK operations and exact generated ML-KEM enum constants
  • validate the generated response through GetAgeSuite() before returning a recipient, while preserving authenticated client reuse, context cancellation, retryable downgrade errors, and cone HTTP error mapping
  • adapt cone call sites to the generated model field names shipped in v1.29.0
  • update x/crypto and go-jose/v4 to the exact releases that clear reachable govulncheck findings

Validation

  • go test ./pkg/client ./cmd/cone
  • go test ./...
  • go test -race ./pkg/client ./cmd/cone
  • go test -count=100 -run 'Test(CreateSecret|RequirePaperSecretAgeSuite)' ./pkg/client
  • make lint (includes gosec)
  • make build
  • go mod verify
  • dependency/vendor second-pass fixpoint: identical diff SHA-256 before and after
  • govulncheck ./...: 0 reachable vulnerabilities
  • no production PaperSecret internal/external endpoint literal or raw create call remains
  • source diff credential-pattern and whitespace audits pass

The canonical v1.29.0 vendored RELEASES.md contains one upstream Markdown hard-break with trailing spaces; the source-only whitespace audit is clean and re-vendoring reproduces the upstream file exactly.

Closes #147.

Related:

This PR must remain unmerged until independent review is complete.

Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
@pquerna
pquerna merged commit b0a56af into main Jul 20, 2026
2 checks passed
@pquerna
pquerna deleted the paul.querna/CONE-147/replace-papersecret-bridge branch July 20, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace PaperSecret Age suite wire bridge with generated SDK

1 participant