Add post-quantum Age support for PaperSecret#146
Merged
Conversation
Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
pquerna
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGE_SUITE_MLKEM768X25519for internal and external PaperSecret creation and reject omitted, legacy, unknown, or mismatched create responsesfilippo.io/agev1.3.1 hybrid recipient implementationCurrent-behavior audit
Before this change, cone omitted the create suite request, did not inspect a returned suite, parsed create recipients as X25519, generated X25519 reader identities, and therefore only supported the legacy Age suite. It could silently accept the API compatibility default during creation.
This change assumes and targets merged ductone/c1 PR #21494 (merge commit
5f8a3873f3537e035923f1e5117d86ca2f7d8f2d). Authenticated GetContent intentionally negotiates through the self-describing hybrid reader recipient and has no suite fields; cone sends only a fresh hybrid recipient and decrypts only with its matching hybrid identity.SDK follow-up
As of this PR, the latest published
conductorone-sdk-gorelease is v1.28.2 and the available generated v1.29.0 PR predates c1 #21494. Neither exposes the merged createrequiredAgeSuite/ responseageSuitefields.pkg/clienttherefore contains a narrow temporary wire bridge for only/api/v1/secrets/internaland/api/v1/secrets/external. It uses cone’s configured authenticated HTTP client and existing generated request/response models. Replace this bridge with generated SDK fields once a post-#21494 SDK revision is published; no raw HTTP use was added for other PaperSecret operations.Verification
go test ./pkg/client ./cmd/conegolangci-lint run ./pkg/client/... ./cmd/cone/...make buildgit diff --check