refactor(uv): delete dead 'dists' packaging path (BE-4351) - #592
refactor(uv): delete dead 'dists' packaging path (BE-4351)#592mattmillerai wants to merge 1 commit into
Conversation
Remove DependencyCompiler.Download, fetch_dep_dists, install_dists, install_wheels, and sync_core_plus_ext. All five had zero call sites anywhere in comfy_cli/ or tests/ (verified by word-boundary grep). The live standalone-install path is wheels-only: standalone.py -> fetch_dep_wheels (Wheel) -> install_wheels_directly, all of which are kept untouched. Download duplicated Wheel modulo the pip subcommand (download vs wheel) and output flag (-d vs -w); its sole caller was fetch_dep_dists, so the duplication disappears with the dead half. Git history preserves the sdist path if a future offline-install feature ever needs it.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)
ELI-5
comfy-clihas a helper class (DependencyCompilerinuv.py) that knows how to fetch and install Python packages for a Comfy workspace. Over time it grew two parallel ways to do the same job:.whlfiles, then install them), andpip download, then install them).Only the wheels path is actually wired up and used (by
standalone.py). The dists path — five methods totaling ~80 lines — is never called from anywhere, has no tests, and had already drifted out of sync with the live path. This PR deletes that dead half. Nothing users can do changes; there's just less unused code to trip over.What changed
Deleted from
comfy_cli/uv.py(pure removal, no behavior change):DependencyCompiler.Download(static method) — a near-duplicate of the keptWheelmethod, differing only in the pip subcommand (downloadvswheel) and output flag (-dvs-w). Its only caller wasfetch_dep_dists.fetch_dep_distsinstall_distsinstall_wheels(note: notinstall_wheels_directly, which is the live one and is kept)sync_core_plus_extKept untouched (the live wheels path):
Wheel,fetch_dep_wheels,install_wheels_directly,install_deps,compile_deps. The live install flow isstandalone.py→fetch_dep_wheels(→Wheel) →install_wheels_directly.Why it's safe
comfy_cli/+tests/) — including string literals and any dynamic dispatch — returns nothing outsideuv.py. Nogetattr-style dispatch onDependencyCompilerexists.standalone.pyonly referencescompile_deps,fetch_dep_wheels,install_wheels_directly, andinstall_deps, all unchanged.2769 passed, 37 skipped.ruff check+ruff format --diffclean.Judgment call / follow-up
DependencyCompiler.Sync(a low-level static pip-syncwrapper) is left in place. Its only caller was the now-deletedsync_core_plus_ext, so it becomes newly-orphaned by this change. It was not in the ticket's explicit deletion list (which enumerated exactly 5 symbols), so I kept the diff scoped and did not delete it as a drive-by — it sits alongside the other primitive pip wrappers (Install,Compile,Wheel). Flagging it as a candidate for a small follow-up cleanup if desired.Testing
uv run --locked --extra dev pytest -q→2769 passed, 37 skippedruff check comfy_cli/uv.py→ All checks passedruff format --diff comfy_cli/uv.py→ already formatted