Repository navigation
Add SLF4J logging instrumentation to ArticleQueryService - #22
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
deleted the
devin/1767908094-add-slf4j-logging-articlequeryservice
branch
April 24, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SLF4J logging instrumentation to the
ArticleQueryServiceclass to provide visibility into method entry and exit points. This includes:Loggerimport and static logger declarationfindById()- logs id parameterfindBySlug()- logs slug parameterfindRecentArticlesWithCursor()- logs tag, author, favoritedBy parametersfindUserFeedWithCursor()- logs user idfindRecentArticles()- logs tag, author, favoritedBy, page parametersfindUserFeed()- logs user id, page parametersReview & Testing Checklist for Human
Pageclass has a meaningfultoString()implementation (it's logged directly infindRecentArticles()andfindUserFeed())Recommended test plan:
./gradlew bootRunto start the serverGET /articlesendpoint and verify entry/exit logs appear in consoleNotes
./gradlew compileJava --no-daemon- build successful/articlesendpoint (showsEntering findRecentArticles()andExiting findRecentArticles()with parameters)actions/cache: v2in the repository's GitHub Actions workflowLink to Devin run: https://partner-workshops.devinenterprise.com/sessions/a97e43e7b2054073b4d76f71ac0e9d2a