Repository navigation
Add SLF4J logging instrumentation to UsersApi controller - #10
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
deleted the
devin/1767908035-add-slf4j-logging-usersapi
branch
April 24, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SLF4J logging instrumentation to the
UsersApicontroller for thecreateUser()anduserLogin()methods. Entry logs capture non-sensitive request parameters (username for registration, email for login), and exit logs mark successful method completion.Changes:
createUser()method (logs username only)userLogin()method (logs email only)Passwords and other sensitive data are explicitly NOT logged.
Review & Testing Checklist for Human
POST /users) and confirm entry/exit logs appearPOST /users/login) and confirm entry/exit logs appearRecommended test plan: Start the application with
./gradlew bootRun, then make requests to/usersand/users/loginendpoints. Check application logs to verify the INFO-level entry/exit messages appear with the expected format.Notes
userLogin()only occurs on successful authentication; failed attempts throwInvalidAuthenticationExceptionbefore reaching the exit log./gradlew compileJava --no-daemonEntering createUser() with username=testuser123/Exiting createUser()Entering userLogin() with email=test@example.com/Exiting userLogin()actions/cache: v2in repository workflow)Link to Devin run: https://partner-workshops.devinenterprise.com/sessions/46c18c1e23cd4a188d0e0952bb899549