Skip to content

Add SLF4J logging instrumentation to UsersApi controller - #10

Closed
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1767908035-add-slf4j-logging-usersapi
Closed

devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1767908035-add-slf4j-logging-usersapi

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jan 8, 2026 •

Copy link
Copy Markdown

Summary

Adds SLF4J logging instrumentation to the UsersApi controller for the createUser() and userLogin() methods. Entry logs capture non-sensitive request parameters (username for registration, email for login), and exit logs mark successful method completion.

Changes:

  • Added SLF4J Logger import and static logger declaration
  • Added INFO-level entry/exit logging to createUser() method (logs username only)
  • Added INFO-level entry/exit logging to userLogin() method (logs email only)

Passwords and other sensitive data are explicitly NOT logged.

Review & Testing Checklist for Human

  • Verify no sensitive data (passwords) is being logged in the implementation
  • Test user registration endpoint (POST /users) and confirm entry/exit logs appear
  • Test user login endpoint (POST /users/login) and confirm entry/exit logs appear

Recommended test plan: Start the application with ./gradlew bootRun, then make requests to /users and /users/login endpoints. Check application logs to verify the INFO-level entry/exit messages appear with the expected format.

Notes

  • Exit logging for userLogin() only occurs on successful authentication; failed attempts throw InvalidAuthenticationException before reaching the exit log
  • Compilation verified locally with ./gradlew compileJava --no-daemon
  • Local testing verified logging output appears correctly:
    • Entering createUser() with username=testuser123 / Exiting createUser()
    • Entering userLogin() with email=test@example.com / Exiting userLogin()
  • CI failure is unrelated to code changes (deprecated actions/cache: v2 in repository workflow)

Link to Devin run: https://partner-workshops.devinenterprise.com/sessions/46c18c1e23cd4a188d0e0952bb899549

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration
devin-ai-integration Bot deleted the devin/1767908035-add-slf4j-logging-usersapi branch April 24, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants