Skip to content

feat(walltime): search NixOS debug info path#354

Open
not-matthias wants to merge 1 commit into
mainfrom
cod-2664-support-nixos-debug-paths-in-runner
Open

feat(walltime): search NixOS debug info path#354
not-matthias wants to merge 1 commit into
mainfrom
cod-2664-support-nixos-debug-paths-in-runner

Conversation

@not-matthias
Copy link
Copy Markdown
Member

Summary

  • Fall back to /run/current-system/sw/lib/debug when /usr/lib/debug doesn't exist, so stripped system libraries resolve on NixOS hosts with environment.enableDebugInfo = true.
  • Each candidate dir is checked for existence before being passed to find_debug_file_in, so missing dirs are silently skipped on either platform.

Test plan

  • cargo test (existing find_debug_file_in tests still cover both build-id and .gnu_debuglink paths)
  • Manual: on NixOS with environment.enableDebugInfo = true, confirm libc symbols resolve in a walltime profile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing cod-2664-support-nixos-debug-paths-in-runner (41842da) with main (149a618)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fall back to /run/current-system/sw/lib/debug when /usr/lib/debug is
absent, so stripped system libraries resolve on NixOS hosts that have
`environment.enableDebugInfo = true`.
@not-matthias not-matthias force-pushed the cod-2664-support-nixos-debug-paths-in-runner branch from 77e1a6c to 41842da Compare May 16, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants