Skip to content

Customization Anti-Crawler options - #845

Merged
alexander-b-clean merged 7 commits into
devfrom
anti-crawler-options.ab
Aug 10, 2026
Merged

Customization Anti-Crawler options#845
alexander-b-clean merged 7 commits into
devfrom
anti-crawler-options.ab

Conversation

@alexander-b-clean

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WordPress admin settings UX so Anti-Crawler (an add-on to SpamFireWall) can automatically enable SpamFireWall when Anti-Crawler is enabled, and enforces that dependency during settings validation.

Changes:

  • Added admin-page JS logic to turn on SpamFireWall when Anti-Crawler is enabled.
  • Updated settings definition/description for Anti-Crawler and adjusted SpamFireWall children/dependency handling.
  • Added server-side validation to force sfw__enabled on when sfw__anti_crawler is enabled, and regenerated minified assets.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File Description
js/src/cleantalk-admin-settings-page.js Adds Anti-Crawler → SpamFireWall dependency handling in the settings UI.
js/cleantalk-admin-settings-page.min.js Rebuilt minified JS including the new dependency handler.
js/cleantalk-admin-settings-page.min.js.map Updated source map to match rebuilt minified JS.
inc/cleantalk-settings.php Updates Anti-Crawler field description and adds validation to enforce the dependency server-side.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread js/src/cleantalk-admin-settings-page.js
Comment thread inc/cleantalk-settings.php Outdated
Comment thread inc/cleantalk-settings.php
Comment thread inc/cleantalk-settings.php Outdated

@alexandergull alexandergull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.03%. Comparing base (7feaba9) to head (72ef830).
⚠️ Report is 36 commits behind head on dev.

Files with missing lines Patch % Lines
inc/cleantalk-settings.php 88.88% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #845      +/-   ##
============================================
+ Coverage     27.63%   28.03%   +0.40%     
- Complexity     6059     6155      +96     
============================================
  Files           282      284       +2     
  Lines         25191    25401     +210     
============================================
+ Hits           6962     7122     +160     
- Misses        18229    18279      +50     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-b-clean
alexander-b-clean merged commit d1859a6 into dev Aug 10, 2026
8 checks passed
@alexander-b-clean
alexander-b-clean deleted the anti-crawler-options.ab branch August 10, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants