Let attendees collapse the chat panel and presenters hide it - #251
Open
nataliamelissas wants to merge 3 commits into
Open
nataliamelissas wants to merge 3 commits into
nataliamelissas wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a phone the attendee room gives the chat panel a fixed share of the viewport. When the
current interaction is a poll, a quiz, or a form with more than a handful of options, the
question and its answers scroll inside roughly 40dvh while the panel below keeps its space,
even when nobody is reading the chat.
This adds two ways to give that space back:
remembered per event in
localStorage, the same pattern the focus slot and the captionpanel already use.
existing ones. It is a new
chat_panel_visiblefield on the presentation state, so itbroadcasts live and survives a reload. It is separate from "deactivate messages": that
keeps the panel and removes the composer, this removes the panel entirely.
In both cases the focus slot takes the freed row, so the interaction uses the whole viewport.
When the panel is hidden with nothing on screen the room shows a short "Waiting for the
presenter" line rather than going blank.
Notes for review
#attendee-roommoves fromgrid-rows-[…]to a flex column. The rows were enumerated inthree static class strings; with a fourth toggle the enumeration doubles, and the flex
version expresses the same layout with
shrink-0on the fixed rows.#focus-slotno longer carries its ownmax-h-[40dvh].That cap was what kept a poll at 40dvh even after the panel was collapsed; the slot's own
height governs now, and the cap stays on the slot for the default layout.
<style>blocks: the collapse states are classes inassets/css/app.css,toggled by the
AttendeeChathook. This keeps the templates usable behind astyle-src 'self'CSP with no hashes.
mix format,mix credo(no issues), andmix test(344 tests) pass;mix gettext.extractand
mix gettext.merge priv/gettexthave been run.