Fix Canvas player NPC region registration during spawn - #3329
Open
RLFrieren wants to merge 1 commit into
Open
Conversation
RLFrieren
force-pushed
the
codex/canvas-region-player-spawn
branch
from
July 27, 2026 01:22
a918879 to
eecf17b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas performs a region ownership check during
ServerLevel#addFreshEntity. A Citizens player NPC reaches that call before its fake network connection is associated with the activeRegionizedWorldData, so Canvas rejects the spawn as an async entity insertion.The player is now positioned before insertion. On Canvas 26.1, the fake connection is attached to the active region only for the insertion operation, then removed in a
finallyblock. The temporary view-distance change is restored there as well.Validation:
mvn -DskipTests -pl v1_21_R7,v26_1_R1,v26_2_R1 -am compile