VV: Compute Feature Centroids full V&V'ed#1658
Merged
imikejackson merged 1 commit intoJul 10, 2026
Merged
Conversation
imikejackson
force-pushed
the
vv/compute_feature_centroids
branch
from
cc7b66e to
0dfb283
Compare
mmarineBlueQuartz
approved these changes
Jul 10, 2026
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
vv/compute_feature_centroids
branch
from
0dfb283 to
8fa3837
Compare
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Jul 15, 2026
…uartzSoftware#1665) The periodic path applied a constant half-domain offset to the naive centroid. That model is only correct when a wrapped feature's mass is symmetric about the seam and can place asymmetric features outside the domain. The prior spacing fix (BlueQuartzSoftware#1658) was necessary but not sufficient. * Reimplement the periodic path as a minimum-image circular mean: accumulate per-feature unit-vector (cos/sin) sums during the cell sweep, and at finalize replace the arithmetic centroid with the circular mean on axes where the feature spans the full extent. A near-zero resultant (domain-filling feature) falls back to the arithmetic mean. Trig is only evaluated when Is Periodic is enabled. * Remove the range-based ImageGeom overload of AdjustCentroidsForPeriodicFaces: per-feature index ranges are mathematically insufficient to compute a wrapped centroid, and it now has no callers. * Re-derive periodic test fixtures D and E against an independent minimum-image oracle (no longer the circular constant-offset oracle), and add Fixture F for the domain-filling fallback. Pass in-core and OOC. * Update the ComputeFeatureCentroids V&V report, deviations, and user docs to reflect the corrected model. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.