Prevent infinite recursion reporting a problem

[StephenMcConnel]

Devin review

---

This change is 

[greptile-apps]

Greptile Summary

Adds a per-thread boolean flag (s_isReporting) to break a mutual-recursion cycle where ShowToast triggers a network/reporting operation that eventually calls back into NonFatalProblem.Report, causing a StackOverflowException.

• The [ThreadStatic] attribute is the right tool here: the recursion is synchronous and same-thread, so per-thread isolation correctly blocks the cycle without affecting unrelated threads.
• The finally block in the new code guarantees the flag is reset even if ShowToast throws, and the guard is placed precisely at the passive/toast code path that produces the cycle.

Important Files Changed

Filename	Overview
src/BloomExe/NonFatalProblem.cs	Adds a [ThreadStatic] reentrancy guard around ShowToast to break the Report → ShowToast → SendBundle → ReportConnectionError → Report recursion cycle; implementation is correct.

_{Reviews (1): Last reviewed commit: "Prevent infinite recursion reporting a p..." | Re-trigger Greptile}

[StephenMcConnel]

🤖 Claude Opus 4.8 (1M context)

Consulted Devin on 2026-07-30 20:46 UTC up to commit 2e72e28.

Re-review clean — 0 Bugs, 0 Investigate flags. Devin raised 2 Informational items (not action-required, not mirrored as threads):

1. The reentrancy guard covers the toast path but not the modal-dialog path. Devin confirms this is safe for the known recursion trigger (ReportConnectionError reports with ModalIf.None, which never takes the modal branch); the modal-path gap is only a hypothetical.
2. Re-entrant reports are suppressed from the user's view but still logged + sent to Sentry — the intended tradeoff.

Both are being surfaced to the developer as FYI/optional-hardening notes. CI (Greptile, pr-automation) is green.

[andrew-polk]

@andrew-polk reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on StephenMcConnel).