Fix production crash: SecurityException in canRequestPackageInstalls()#1521
Open
wyqlxf wants to merge 3 commits into
Open
Fix production crash: SecurityException in canRequestPackageInstalls()#1521wyqlxf wants to merge 3 commits into
wyqlxf wants to merge 3 commits into
Conversation
wyqlxf
changed the title
wyqlxf
force-pushed
the
fix-1502
branch
2 times, most recently
from
1491790 to
6a3c55c
Compare
Author
|
@CanadianN1nj4 Could you please review this? |
|
@wyqlxf I'm not actually an approving reviewer, just thought some PR's looked good |
…t REQUEST_INSTALL_PACKAGES Wrap canRequestPackageInstalls() in try-catch to prevent crash when app has not declared REQUEST_INSTALL_PACKAGES in manifest. Fixes Baseflow#1502 Co-authored-by: Cursor <cursoragent@cursor.com>
- Replace baseflow_plugin_template with minimal MaterialApp example - Update compileSdk to 36, AGP to 8.9.1, and Gradle to 8.11.1 Co-authored-by: Cursor <cursoragent@cursor.com>
Align Java compile target with Kotlin (17) to resolve CI assembleRelease failure. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
@mvanbeusekom Could you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #1502
Apps that do not declare
REQUEST_INSTALL_PACKAGESin their AndroidManifest.xml will crash withSecurityExceptionwhencanRequestPackageInstalls()is called. This commonly affects apps that cannot add this permission due to Google Play Store policy restrictions.Wrap
canRequestPackageInstalls()calls in try-catch forSecurityExceptionin bothPre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.