Skip to content

Add weekly-demo-video and weekly-report Copilot skills#8099

Open
rajeshkamal5050 wants to merge 5 commits intomainfrom
feature/weekly-skills
Open

Add weekly-demo-video and weekly-report Copilot skills#8099
rajeshkamal5050 wants to merge 5 commits intomainfrom
feature/weekly-skills

Conversation

@rajeshkamal5050
Copy link
Copy Markdown
Contributor

@rajeshkamal5050 rajeshkamal5050 commented May 7, 2026

Fixes #8033

Adds two Copilot CLI skills for automated weekly workflows:

weekly-demo-video

Generates narrated MP4 demo videos for azd features using Python + Pillow + edge-tts + ffmpeg. Includes full pipeline conventions, color palette, slide type specs, and cross-platform font support.

weekly-report

Generates weekly executive reports for LT. Includes section rules and iteration workflow.

Files

  • .github/skills/weekly-demo-video/SKILL.md — demo video workflow
  • .github/skills/weekly-demo-video/references/CONVENTIONS.md — video style rules
  • .github/skills/weekly-report/SKILL.md — report workflow
  • .github/skills/weekly-report/references/SECTION-RULES.md — section format rules

Adds Copilot CLI skills for automated weekly workflows:
- weekly-demo-video: generates narrated MP4 demo videos
- weekly-report: generates weekly feature summaries for LT

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 7, 2026 23:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🔗 Linked Issue Required

Thanks for the contribution! Please link a GitHub issue to this PR by adding Fixes #123 to the description or using the sidebar.
No issue yet? Feel free to create one!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new Copilot CLI workflow skills under .github/skills/ to standardize (1) a weekly narrated demo-video pipeline and (2) a weekly executive status report workflow for the azd team.

Changes:

  • Add weekly-demo-video skill and its detailed video-style/pipeline conventions reference.
  • Add weekly-report skill plus reference docs for section structure and tone rules.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/skills/weekly-demo-video/SKILL.md Defines the weekly demo video workflow and steps to generate narrated MP4 demos.
.github/skills/weekly-demo-video/references/CONVENTIONS.md Captures the rendering, audio, palette, font, and slide-type conventions for consistent videos.
.github/skills/weekly-report/SKILL.md Defines the weekly exec report workflow (data gathering, changelog review, iteration loop).
.github/skills/weekly-report/references/SECTION-RULES.md Defines strict per-section formatting/content rules for the report.
.github/skills/weekly-report/references/TONE-RULES.md Defines tone/style constraints and common iteration patterns for report edits.

Comment thread .github/skills/weekly-report/SKILL.md Outdated
Comment thread .github/skills/weekly-report/SKILL.md
Comment thread .github/skills/weekly-demo-video/SKILL.md Outdated
Comment thread .github/skills/weekly-demo-video/SKILL.md Outdated
Copy link
Copy Markdown
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Code Review — PR #8099

Add weekly-demo-video and weekly-report Copilot skills


🔴 P1 — Must Fix

1. CI Failing — No linked GitHub issue
📍 PR description
The pr-governance check is failing. Add Fixes #XXXX to the PR description or link an issue via the sidebar. This is a hard merge gate.

2. macOS-only install instructions
📍 weekly-demo-video/SKILL.md — Prerequisites table
Install commands use brew install exclusively, but this repo is actively developed on Windows (the skill itself includes Windows font paths). Add winget/choco alternatives for Windows and apt for Linux, or replace with a generic "Ensure Python 3, Pillow, ffmpeg, and edge-tts are installed."


🟡 P2 — Should Fix

3. No error handling guidance for video generation pipeline
📍 weekly-demo-video/SKILL.md — Step 5
The pipeline chains Python → edge-tts → ffmpeg with no recovery guidance. What should the agent do if edge-tts fails (rate limits, network) or ffmpeg errors on a slide? Add a brief error handling section.

4. Undocumented dependency on changelog-generation skill
📍 weekly-report/SKILL.md — Step 3
The weekly-report reads from changelog files that the changelog-generation skill writes. This implicit dependency should be documented (e.g., "Changelog data is maintained by the changelog-generation skill.").

5. Undefined "session files directory" output location
📍 weekly-report/SKILL.md — Output section
"Save reports to the session files directory" — but this is never defined. An AI agent won't know where to save. Reference the session workspace path or clarify the intended output location.

6. Missing INVOKES: line in frontmatter descriptions
📍 Both SKILL.md files
Existing skills (changelog-generation, azd-preflight, sensei) include an INVOKES: line listing tools/agents. Both new skills omit this. Add:

  • weekly-demo-video: INVOKES: Python, Pillow, ffmpeg, edge-tts, explore sub-agents, ask_user.
  • weekly-report: INVOKES: gh CLI, git CLI, explore sub-agents, ask_user.

🟢 P3 — Suggestions

7. Strengthen anti-trigger references — Existing skills reference specific alternatives in DO NOT USE FOR: (e.g., "creating PRs (use pull-request)"). Consider adding: weekly-report: "release changelogs (use changelog-generation), daily standup (use standup-report)".

8. Add concrete date range example — The YYYY-MM-DD placeholders in weekly-report Step 2 would benefit from a real example showing the Thursday-to-Thursday cadence.

9. Consider adding license and metadata.version fields — Some existing skills include these; adding them to new skills would be good hygiene.


✅ What Looks Good

  • No skill overlap conflicts — trigger phrases are distinct, no routing ambiguity
  • Reference files are well-structured and follow established references/ patterns
  • Changelog paths verified — all three referenced files exist
  • Tone rules reflect real iteration (9+ weeks) — prescriptive but effective
  • Video conventions are comprehensive (color palette, fonts, slide types, ffmpeg pipeline)

rajeshkamal5050 and others added 2 commits May 7, 2026 16:10
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add license: MIT and metadata.version to both skill frontmatters
- Add INVOKES: line to both descriptions
- Make install instructions cross-platform (generic)
- Add prerequisites (gh, jq) to weekly-report
- Add error handling section to weekly-demo-video
- Document changelog-generation skill dependency
- Define session workspace output path for weekly-report
- Strengthen anti-trigger references in DO NOT USE FOR
- Add concrete date range examples
- Remove TONE-RULES.md and its reference

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rajeshkamal5050
Copy link
Copy Markdown
Contributor Author

All review feedback addressed in commit 4052e51:

# Issue Fix
P1-1 No linked issue Linked Fixes #8033 in PR description
P1-2 macOS-only installs Replaced with generic tool table, no brew references
P2-3 No error handling Added Error Handling section (edge-tts retry, ffmpeg stop, font fallback)
P2-4 Undocumented changelog-generation dep Added note: "Changelog data is maintained by the changelog-generation skill"
P2-5 Undefined session files directory Clarified to ~/.copilot/session-state/<session-id>/files/
P2-6 Missing INVOKES line Added to both: Python, Pillow, ffmpeg, edge-tts, explore sub-agents, ask_user and gh CLI, jq, git CLI, explore sub-agents, ask_user
P3-7 Anti-trigger references Added changelog-generation and weekly-report/weekly-demo-video cross-references
P3-8 Concrete date range Added real examples (May 1–8 2026) in both skills
P3-9 Missing license/version Added license: MIT and metadata: version: "1.0" to both

Also added gh, jq, git prerequisites table to weekly-report per copilot bot feedback.

@rajeshkamal5050 rajeshkamal5050 requested a review from wbreza May 7, 2026 23:17
Copy link
Copy Markdown
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-Review — New Commit \�074fe9\

New Concern: Tone Rules Removal

The second commit removes \weekly-report/references/TONE-RULES.md\ and its inclusion from \SKILL.md. The initial review noted the tone rules as a strength — they encoded 9+ weeks of iteration on voice, severity calibration, hype-word avoidance, and user edit patterns.

Without these rules, the weekly-report skill loses guidance on:

  • Avoiding hype words ("turning point", "game changer", "significant milestone")
  • Calibrating commitment language ("being explored" vs "targeting")
  • Handling rapid user edit cycles (surgical removals, consistency checks)
  • Keeping content product-focused (no names, no org changes)

Recommendation: If tone rules are being removed from this PR intentionally, consider whether they should live elsewhere (e.g., in \skill-guidance\ as per-user preferences) or be re-added in a follow-up. Without them, expect more iteration cycles when generating reports.

Prior Findings — Still Unaddressed

All 6 P1/P2 findings from the initial review remain open:

Priority Finding Status
P1 Missing linked GitHub issue (CI blocker) Unaddressed
P1 macOS-only install instructions Unaddressed
P2 No error handling for video pipeline Unaddressed
P2 Undocumented dependency on changelog-generation Unaddressed
P2 Undefined "session files directory" output location Unaddressed
P2 Missing INVOKES line in frontmatter Unaddressed

Copy link
Copy Markdown
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Code Review — PR #8099

Author addressed all prior P1/P2/P3 feedback in 4052e5149. A few items remain:

🟡 P2 — Hardcoded May 2026 dates in executable commands

Both skills bake the literal date range 2026-05-01..2026-05-08 into commands that agents will run as-is. Step 1 says "confirm date range," but Step 2''s code blocks still contain the example dates — agents copy commands literally and will query last-week-of-May-2026 every week.

📍 .github/skills/weekly-report/SKILL.md — Step 2

gh pr list ... --search "merged:2026-05-01..2026-05-08" ...
gh issue list ... --search "closed:2026-05-01..2026-05-08" ...
gh api ... | jq ''... select(.published_at >= "2026-05-01" and .published_at <= "2026-05-08") ...''

📍 .github/skills/weekly-demo-video/SKILL.md — Step 2

git log --oneline --since="2026-05-01" --until="2026-05-08" --no-merges

Fix: use placeholder syntax ({{ start_date }}..{{ end_date }}) or add an explicit "replace 2026-05-01 and 2026-05-08 with the dates from Step 1" callout above each code block.

🟢 P3 — weekly-demo-video writes MP4s into the repo working tree

📍 .github/skills/weekly-demo-video/SKILL.md — Output section

<repo-root>/demo-video/ leaves video artifacts in the working copy and risks accidental commits. The sibling weekly-report skill correctly writes to ~/.copilot/session-state/<session-id>/files/.

Fix: either align with the session-workspace convention, or add demo-video/ to .gitignore and document that in the skill.

🟢 P3 — Prerequisite check is POSIX-shell-only

📍 .github/skills/weekly-demo-video/SKILL.md — Prerequisites section

python3 -c "from PIL import Image; print(''ok'')" && ffmpeg -version >/dev/null 2>&1 && edge-tts --list-voices >/dev/null 2>&1

The previous round removed brew install for cross-platform parity, but python3, >/dev/null 2>&1, and && chaining still won''t work in Windows PowerShell. Either label the block as bash explicitly, or split into discrete cross-shell checks.

✅ Looks good

  • All prior P1/P2/P3 feedback addressed
  • Frontmatter (license, metadata.version, INVOKES) added to both skills
  • Error handling section added
  • changelog-generation dependency documented
  • Anti-trigger cross-references added

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@rajeshkamal5050 rajeshkamal5050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tone rules — was too personal, rewrote it for the team. Restored in 255329a.

P1/P2s — all fixed in 4052e51. Take a look at the latest commits when you get a chance.

@rajeshkamal5050 rajeshkamal5050 requested a review from wbreza May 7, 2026 23:49
- Replace hardcoded May 2026 dates with placeholders in both skills
- Add demo-video/ to .gitignore to prevent accidental commits
- Split prereq check into discrete commands (cross-shell friendly)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@rajeshkamal5050 rajeshkamal5050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0f7981a:

  • Dates — replaced hardcoded May 2026 with placeholders. Added callout to substitute from Step 1.
  • gitignore — added demo-video/ to .gitignore.
  • Prereq check — split into discrete commands, no more chained && with redirects.

@rajeshkamal5050 rajeshkamal5050 requested a review from hemarina May 7, 2026 23:51
Copy link
Copy Markdown
Member

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things prior reviews didn't catch:

  1. Both skills' descriptions miss the **WORKFLOW SKILL** - prefix that all three existing skills consistently use (azd-preflight, changelog-generation, sensei). Quick fix in the frontmatter description: field.

  2. Fixes #8033 will auto-close the issue on merge, but the issue title includes "issues and epics hygiene" which isn't in this PR. Consider Partially addresses #8033 or split the issue so remaining work stays tracked.

The fixes from the two prior review rounds are all in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-governance Skip PR governance checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create skills for weekly reports, issues and epics hygiene

5 participants